Skip to content

[game] Add bash support for eligible doors#104

Open
Eldbury wants to merge 2 commits intomodawan:masterfrom
Eldbury:fix/door-bash
Open

[game] Add bash support for eligible doors#104
Eldbury wants to merge 2 commits intomodawan:masterfrom
Eldbury:fix/door-bash

Conversation

@Eldbury
Copy link
Copy Markdown

@Eldbury Eldbury commented Apr 26, 2026

Summary

Adds door bash support for eligible locked doors.

Locked, selectable, non-plot, blastable hostile doors now expose the existing Attack context action. Door damage now reduces HP and opens/unlocks the door when HP reaches zero.

Scope

  • Uses existing AttackObject context action and icon
  • Uses door faction via IReputes::getIsEnemy(Faction, Faction)
  • Honors Plot and NotBlastable
  • Does not implement placeable bash, Security DC rolls, key handling, or Slice/ComputerUse

Testing

  • Built engine and launcher in RelWithDebInfo on Windows
  • Ran git diff --check upstream/master...HEAD
  • Verified branch diff only includes door/reputes/module files

Manual verification

  • K1 Dantooine locked hostile non-plot door: Attack appears and damages the door
  • K1 unlocked ordinary door: Attack does not appear
  • K1 plot door: Attack does not appear
  • K1 Endar Spire Security tutorial door: Security still works

Known issues

  • K2 door bash not yet implemented
  • Container bash / security interactions not yet implemented


_dead = true;
_locked = false;
open();
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to run Door::onOpen here to call the corresponding script.

Currently Door::onOpen takes an Object &triggerer parameter, but I don't think that is necessary, since it doesn't need anything other than triggerer's ID. We can change that, and use damager as triggerer for onOpen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants